ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
11.02k stars 17.57k forks source link

RCInput_UDP feature request - Navio2 hardware #7636

Closed drobban closed 3 years ago

drobban commented 6 years ago

Issue details

Needed Joystick via network functionality. So I read the ardupilot source code to find out where to incorporate this functionality. As I was doing this, I found that someone else before me had done this for the Bebop hardware. So I changed some lines to add support for this in the Navio2 hardware as well and is now wondering if this is something that the ardupilot would accept an pull request on? If so, I just have to make it "commit-able" before I can submit an request.

RCInput_UDP for Navio2

Version

Arducopter-3.5

Platform

[ ] All [ ] AntennaTracker [ x ] Copter [ ] Plane [ ] Rover [ ] Submarine

Hardware type

Navio2

auturgy commented 6 years ago

I’m not sure that UDP is the best protocol for control (as there’s no guarantee of delivery), but it probably isn’t really worse than many others. Pull requests are always welcome!

peterbarker commented 6 years ago

On Mon, 30 Jul 2018, auturgy wrote:

I’m not sure that UDP is the best protocol for control (as there’s no guarantee of delivery), but it probably isn’t really worse than many

No, lossy is good here. I'd prefer my vehicle NOT process (e.g.) an arming command which was issued 5 minutes ago but has been sitting in a buffer somewhere....

drobban commented 6 years ago

Sorry for the late reply, must of missed the notification. I have a test version I run on my own hardware. The version I run with isn't production quality, but that is something I intended to change in the event of someone giving a go on this issue.

Been a while since I messed with the code, but if I remember correctly there is configuration options for radio and such and that I planned to extend the configs with UDP options.

Agree with @peterbarker regarding UDP.

peterbarker commented 3 years ago

@drobban are you still interested in chasing this?

IamPete1 commented 3 years ago

No response so i'm going to close, I think we answered the question anyway, "yes a PR for that would be Great"