search

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
11.02k stars 17.57k forks source link

Copter: Compassmot polls the battery excessively fast #7976

Open WickedShell opened 6 years ago

WickedShell commented 6 years ago

Issue details

Copter manually polls the battery read function at 50Hz within the compassmot, this in turn updates the resistance at 50Hz. The filter for this was setup and tuned at a 10Hz call rate, and thus will create different results then would be seen in normal usage. This also logs total consumed with a 5x scalar, but that is at least a safer direction of error.

This should probably be rate limited within the compassmot test, however I didn't want to address this until after the battery failsafe stuff is merged first due to the ever ongoing scope creep.

Platform

[ ] All [ ] AntennaTracker [ x ] Copter [ ] Plane [ ] Rover [ ] Submarine

amilcarlucas commented 6 years ago

Are all your battery PRs now in master ?

WickedShell commented 6 years ago

Except #8025 which is stuck on me finishing moving some params I missed earlier.

amilcarlucas commented 3 years ago

@WickedShell the PR #9414 got merged already. It replaced #8025 that was blocking this. So this one can be re-activated again.