search

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
10.98k stars 17.52k forks source link

Autotest for Tradheli giving false positive on arm features test #9682

Closed bnsgeyer closed 6 years ago

bnsgeyer commented 6 years ago

Issue details when autotest is run for tradheli, it fails the arm features test. In particular it is failing during the specific arming test for tradheli that checks for that the motors interlock does not enable with the aircraft disarmed. The error given in the autotest log is AUTOTEST: FAILED: "Arm features": ValueError('Message has no servo8_raw field',)

When I test for this using the SITL, the code is working properly and does not allow me to enable motor interlock with the aircraft disarmed. So I'm guessing something has changed with datafields for the Servo messages.

By the way, this arming feature test should not be done just for tradheli. This is applicable to anyone using motor interlock

Version Master ArduCopter V3.7-dev (49ce9d02)

Platform [ ] All [ ] AntennaTracker [X] Copter [ ] Plane [ ] Rover [ ] Submarine

Airframe type tradheli

Hardware type SITL

Logs latest autotest log

peterbarker commented 6 years ago

On Fri, 2 Nov 2018, Bill Geyer wrote:

when autotest is run for tradheli, it fails the arm features test. In particular it is failing during the specific arming test for tradheli that checks for that the motors interlock does not enable with the aircraft disarmed. The error given in the autotest log is AUTOTEST: FAILED: "Arm features": ValueError('Message has no servo8_raw field',)

I've pushed in a fix for that....

By the way, this arming feature test should not be done just for tradheli. This is applicable to anyone using motor interlock

This is quite true. I don't know why it is guarded.

khancyr commented 6 years ago

other vehicles don't have interlock feature, so we cannot test it .

bnsgeyer commented 6 years ago

@khancyr multicopters have the option to use the motor interlock. Many probably don't but I know @lthall has told me that he uses it on his large quadcopters. So I would test it for all multirotor frames.

bnsgeyer commented 6 years ago

@peterbarker thanks for the quick turn around for the fix.

peterbarker commented 6 years ago

On Sun, 4 Nov 2018, Pierre Kancir wrote:

other vehicles don't have interlock feature, so we cannot test it .

RC Option 32. Applicable to Sub and MultiCopters, too.