search

ArduPilot / ardupilot_gazebo

Plugins and models for vehicle simulation in Gazebo Sim with ArduPilot SITL controllers
GNU Lesser General Public License v3.0
82 stars 78 forks source link

IGN -> GZ #27

Closed ahcorde closed 2 years ago

ahcorde commented 2 years ago

Build on top of this other PR https://github.com/ArduPilot/ardupilot_gazebo/pull/26

khancyr commented 2 years ago

@ahcorde this is specific to only garden, right ? forteress isn't impact ?

srmainwaring commented 2 years ago

@khancyr yes that's right - Garden only.

@ahcorde I've been making similar changes for another Gazebo plugin (my marine ocean one), wondering if it is worth waiting until the Gazebo Garden interface is finalised before merging this change as I've been through a few iterations catching up as the namespace migration progresses; on the other hand the namespace changes may be breaking for Garden.

ahcorde commented 2 years ago

we are still migrating ign -> gz,

I openned this PR just in case someone want to try this with Garden. I will try to keep it updated

srmainwaring commented 2 years ago

@ahcorde is the reset functionality required by the ign -> gz migration or is it optional? If it's optional we should split that into a separate PR.

ahcorde commented 2 years ago

@srmainwaring for now it's not optional, If I'm able to make it optional I will open another PR

ahcorde commented 2 years ago

Hi @srmainwaring @khancyr,

this is ready for a review