search

ArduPilot / ardupilot_gz

Tools for ArduPilot ROS2 integration and testing on ROS 2 humble
GNU General Public License v3.0
27 stars 19 forks source link

Handle microxrceddsgen dependency #19

Closed pedro-fuoco closed 11 months ago

pedro-fuoco commented 1 year ago

When following the README in a fresh computer microxrceddsgen was not installed like the rest of the dependencies, would it be possible to install it with vcs with the other packages? Screenshot from 2023-06-18 19-40-16 I'd happily implement this to learn more, I just want to know if there's a reason why it isn't there beforehand @srmainwaring

pedro-fuoco commented 1 year ago

To go around it I followed the README at ardupilot/library/AP_DDS/

srmainwaring commented 1 year ago

I just want to know if there's a reason why it isn't there beforehand

The microxrceddsgen package was included in the initial draft of the rosdep file for macOS. It was dropped because it is also included in the AP_DDS instructions and is a java project that does not have a CMakeLists.txt to build with colcon (so you'd have to build manually in any case).

pedro-fuoco commented 1 year ago

Fair point. I think it should be mentioned that users need to go ahead and follow this part in the AP_DDS instructions then. Otherwise there's no way to guess this without asking someone. I could submit a PR to add this to the "Prerequisites" part of the README

pedro-fuoco commented 12 months ago

@srmainwaring what do you think?

tejalbarnwal commented 11 months ago

Fair point. I think it should be mentioned that users need to go ahead and follow this part in the AP_DDS instructions then. Otherwise there's no way to guess this without asking someone. I could submit a PR to add this to the "Prerequisites" part of the README

I second this

srmainwaring commented 11 months ago

Closed by #22