search

ArduPilot / ardupilot_ros

ArduPilot ROS integration
GNU General Public License v3.0
15 stars 9 forks source link

ardupilot_ros: removed cartographer dependency #4

Open snktshrma opened 2 years ago

Ryanf55 commented 1 year ago

Could you explain your reason you intend to remove usage of cartographer? We use cartographer in ROS 2.

snktshrma commented 1 year ago

Hi @Ryanf55 ! Actually adding cartographer as a dependency to package.xml was causing some errors while building the package. So I resorted to remove it from package.xml dependencies and added instructions to install it manually in readme through cartographer’s rosinstall script.

Ryanf55 commented 1 year ago

Hi @Ryanf55 ! Actually adding cartographer as a dependency to package.xml was causing some errors while building the package. So I resorted to remove it from package.xml dependencies and added instructions to install it manually in readme through cartographer’s rosinstall script.

Ok. Would you be able to share the error you get?

snktshrma commented 1 year ago

@Ryanf55, The error was because rosdep was not able to find cartographer_ros package. That's why i had to remove it from here.

Ryanf55 commented 1 year ago

cartographer_ros

Which ROS1 distribution is this for?

snktshrma commented 1 year ago

@Ryanf55, as per official docs, it is for melodic as well as noetic