search

ArduPilot / mavlink

MAVLink micro air vehicle marshalling / communication library
http://qgroundcontrol.org/mavlink/start
Other
63 stars 286 forks source link

Move SPEED_TYPE enumeration to common.xml, use it in DO_CHANGE_SPEED #330

Closed peterbarker closed 1 year ago

peterbarker commented 1 year ago

Cherry-picked from upstream

I've reverted the description change as another patch; I don't know whether we actually honour that description in ArduPilot. We may persist this across mode changes, I haven't checked.

hamishwillee commented 1 year ago

Re description change - which one? "Change speed and/or throttle set points" isn't a change.

peterbarker commented 1 year ago

Re description change - which one? "Change speed and/or throttle set points" isn't a change.

The statement that the speed reverts on mode change - I'm not 100% sure that applies on all ArduPilot vehicles. We may retain the specified speed when going between Plane LOITER and Plane GUIDED modes, for example.

I haven't tested - but if the author of the change can say they have tested such things we could make that change :-)

hamishwillee commented 1 year ago

The statement that the speed reverts on mode change

Ah, the text has always said "setpoint" so it probably should revert on mode change.