search

ArduPilot / mavlink

MAVLink micro air vehicle marshalling / communication library
http://qgroundcontrol.org/mavlink/start
Other
63 stars 286 forks source link

common.xml: deprecate the _INT frames #356

Closed peterbarker closed 8 months ago

peterbarker commented 8 months ago

the frame of an altitude is not dependent on how the altitude is being transported (how other fields in the same message are being transported).

ArduPilot has treated these frames to be the same as the non-_INT equivalents in most places for a very long time.

We can save some confusion and perhaps a small amount of flash space if we remove the _INT frames

Upstream PR is here: https://github.com/mavlink/mavlink/pull/2092

rmackay9 commented 8 months ago

Sounds good to me. We can't really remove the _INT any time soon but marking them deprecated at least removes some essentially identical options that could lead to confusion.

peterbarker commented 8 months ago

The upstream PR is much-improved from this one; I'll be resetting the content of this PR to whatever gets merged upstream at this point.

peterbarker commented 8 months ago

I've reset the content of this PR to be the much-improved-by- @hamishwillee version merged into mavlink/mavlink

hamishwillee commented 8 months ago

@peterbarker Really appreciate all this cleanup stuff.