rubocop on Windows: 22 files inspected, 22 offenses detected

Arduino-CI / arduino_ci

Unit testing and Continuous Integration (CI) for Arduino libraries, from a Ruby gem

Apache License 2.0

110 stars 34 forks source link

rubocop on Windows: 22 files inspected, 22 offenses detected #315

Closed jgfoster closed 1 year ago

jgfoster commented 3 years ago

It complains about CR characters being present but the test does not fail. This raises a couple questions:

If we have an automated test that reports a problem but the framework doesn't tell us about it, then something is broken.
Why do 22 files have CR on Windows?

ianfixes commented 3 years ago

I wonder if this has anything to do with the text=auto setting that we had applied earlier in the git config

jgfoster commented 3 years ago

That's something that I'm investigating as part of #314 (and once we merge that we can revisit this). But even if it does explain the second issue it doesn't address the first issue of failing tests that aren't being reported by the CI system (see here for the problem).

jgfoster commented 3 years ago

When rubocop and rspec are combined in one job, a failure in rubocop will be ignored. But if they are separated then the error will be caught. Compare the Linux workflow with the Windows workflow.

ianfixes commented 3 years ago

I think they should definitely be separated. Also, I should set something up for presenting the rubocop failures as line-level annotations in the diff, not just a pass/fail.

Note to self: https://github.com/marketplace/actions/rubocop-annotate-action