search

Arduino-CI / arduino_ci

Unit testing and Continuous Integration (CI) for Arduino libraries, from a Ruby gem
Apache License 2.0
110 stars 34 forks source link

Align assertion statements; change some stderr to stdout and flush #322

Closed pianistrevor closed 2 years ago

pianistrevor commented 2 years ago

Highlights from CHANGELOG.md

Issues Fixed

ianfixes commented 2 years ago

Please convert tabs to spaces in your code

ianfixes commented 2 years ago

Let's delay merging this until we get more discussion on #321. I'd also like some reassurance that cout << "blah" << flush is functionally equivalent (in terms of segfaults) to cerr << "blah".

I don't mean to be pedantic about this, but the original code I wrote use cout instead of cerr and I made the switch after troubleshooting unit tests that had segfaults in them: https://github.com/adafruit/Adafruit-WS2801-Library/pull/20

In other words, cerr was the difference between seeing and not seeing the source of that segfault.

pianistrevor commented 2 years ago

I think I'll take just the indentation and apply suggested changes in a new PR, while holding off on the cerr discussion.