AreaFiftyLAN / lancie-frontend

Website for Area FiftyLAN
https://areafiftylan.nl
MIT License
5 stars 5 forks source link

Chrome autofill doesn't work on login form #318

Open MatthijsKok opened 7 years ago

MatthijsKok commented 7 years ago

Steps to reproduce:

martijnjanssen commented 7 years ago

Could you find out what makes a form compliant to the chrome autofill options? I believe this is a matter of changing the field names.

martijnjanssen commented 7 years ago

I think the chrome auto-fill does not work because there are no <form> tags around the inputs. I'll have to check though.

MatthijsKok commented 7 years ago

I fixed this, just never pushed.

around it fixes the issue. However, the "Save password?" popup never happens since we do not post the form, or redirect to a different case. So only the username will be autofill, not the password.

martijnjanssen commented 7 years ago

I have a fix in mind for this that is fairly easy and will remove the checking complexity from the element. It should be fixable with an <iron-form>.

TimvdLippe commented 7 years ago

iron-form PR was merged, but it does not appear to work still

martijnjanssen commented 7 years ago

I think this is a more promising way of fixing the problem.

martijnjanssen commented 7 years ago

Okay, @timvdlippe and I have found the problem. It does actually work, But since there are multiple login forms in the page, only the first one has autofill. In our case, the first one is the one in my-area. This one does indeed have autofill.

martijnjanssen commented 6 years ago

The lastpass password manager now works on the website, I'm not sure about the other methods.

skamoen commented 6 years ago

Keepass works too. Good enough to close this, unless we hear about about another big one not working.