search

AreaFiftyLAN / toornament-client

A java api client for Toornament. Currently not under active development.
MIT License
1 stars 1 forks source link

ToDo list #1

Closed BrentonPoke closed 6 years ago

BrentonPoke commented 7 years ago

What still needs to be implemented here? I'm planning on building something for Overwatch and want to start with this, but not sure how far along this is. It looks like you have the authentication down and the skeleton for getting the endpoints, but query-building seems to be missing. Can others contribute to this?

skamoen commented 7 years ago

Hi! Thanks for creating an issue, it's really awesome to see someone actually wanting to use this outside of our little organization!

As stated in the readme, this is very early in development and I wasn't really planning on using this anywhere outside our own usecase. However, if you want to use this, I'm more than willing to speed up development and allow for contributions.

I have a very busy week ahead of me, but I'll definitely get back to you before the end of next week with a list of stuff to do and a contributor plan.

BrentonPoke commented 7 years ago

Sweet. I created a pull request about 5 minutes before you posted. Small additions, but ones that seem to be needed.

edit: I see you responded to it already.

skamoen commented 7 years ago

I investigated the Lombok issues, but I didn't found a solution I'm happy with. Easiest solution is to remove Lombok and just use regular getters and setters, which I just did.

The editorconfig should deal with the odd diffs, and you can add getters and setters where deemed necessary.