Log error and abort generation if viewer script does not exist

austinmatherne-wk commented 7 months ago

Resolves #617

Download and copy script into output directory if it's an http URL.
Log an error and abort generation if script is to a file that doesn't exist or can't be downloaded.
Add new --viewer-no-copy-script (also available in the GUI) option to skip copying or validating --viewer-url and trust the user to provide a valid script location.
Don't open local viewer if generation failed.
Include standard message codes on all Arelle logs.
Fix a variable typo.

Test valid and invalid script URLs from both the GUI and CLI with and without the copy script option.

review: @Arelle/arelle @paulwarren-wk

aviary2-wf commented 7 months ago

Security Insights

No security relevant content was detected by automated scans.

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

derekgengenbacher-wf commented 7 months ago

QA +10 Testing locally succeeded.