Arelle / ixbrl-viewer

The Arelle iXBRL Viewer allows Inline XBRL (or iXBRL) reports to be viewed interactively in a web browser. The viewer allows users to access the tagged XBRL data embedded in an iXBRL report.
Other
94 stars 57 forks source link

Don't Process Non-iXBRL Models #721

Closed austinmatherne-wk closed 2 weeks ago

austinmatherne-wk commented 2 weeks ago

Reason for change

If the iXBRL plugin is enabled and a non-iXBRL report is loaded an exception is thrown.

[viewer:exception] Exception 'ModelFact' object has no attribute 'format' 
Traceback ['  File "/Applications/Arelle.app/Contents/MacOS/plugin/iXBRLViewerPlugin/__init__.py", line 119, in processModel\n    pluginData(cntlr).builder.processModel(modelXbrl)\n', '  File "/Applications/Arelle.app/Contents/MacOS/plugin/iXBRLViewerPlugin/iXBRLViewer.py", line 412, in processModel\n    self.addFact(report, f)\n', '  File "/Applications/Arelle.app/Contents/MacOS/plugin/iXBRLViewerPlugin/iXBRLViewer.py", line 282, in addFact\n    if f.format is not None:\n       ^^^^^^^^\n']

Description of change

Check that the report is iXBRL before processing.

Steps to Test

review: @Arelle/arelle @paulwarren-wk

aviary3-wk commented 2 weeks ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

aaroncameron-wk commented 2 weeks ago

QA +10