Arena-Rosnav / arena-rosnav

MIT License
53 stars 35 forks source link

ROS_ERROR bug in dyn_astar.h #77

Open TravisHC opened 10 months ago

TravisHC commented 10 months ago

hi I found there an extra "%d" in #109 in dyn_astar.h, which will cause compile error. Please fix it. ROS_ERROR("Ran out of pool, index=%d %d %d", idx(0), idx(1));ROS_ERROR("Ran out of pool, index=%d %d", idx(0), idx(1));

sunnyhello369 commented 10 months ago

I have the same problem when run catkin_make [sad]

[ 85%] Built target flatland_viz_autogen In file included from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/intermediate_planner.h:6, from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp:1: /home/dmz/arena_ws/src/arena-rosnav/utils/misc/path_search/include/path_search/dyn_astar.h: In member function ‘bool AStar::Coord2Index(const Vector2d&, Eigen::Vector2i&) const’: /home/dmz/arena_ws/src/arena-rosnav/utils/misc/path_search/include/path_search/dyn_astar.h:109:13: warning: format ‘%d’ expects a matching ‘int’ argument [-Wformat=] 109 ROS_ERROR("Ran out of pool, index=%d %d %d", idx(0), idx(1)); ^~~~~~~~~ /opt/ros/noetic/include/ros/console.h:351:165: note: in definition of macro ‘ROSCONSOLE_PRINT_AT_LOCATION_WITH_FILTER’ 351 ::ros::console::print(filter, rosconsole_define_locationloc.logger_, rosconsole_define_locationloc.level_, FILE, LINE, ROSCONSOLE_FUNCTION, VA_ARGS) ^~~ /opt/ros/noetic/include/ros/console.h:390:7: note: in expansion of macro ‘ROSCONSOLE_PRINT_AT_LOCATION’ 390 ROSCONSOLE_PRINT_AT_LOCATION(__VA_ARGS__); \ ^~~~~~~~ /opt/ros/noetic/include/ros/console.h:575:35: note: in expansion of macro ‘ROS_LOG_COND’ 575 #define ROS_LOG(level, name, ...) ROS_LOG_COND(true, level, name, __VA_ARGS__) ^~~~ /opt/ros/noetic/include/rosconsole/macros_generated.h:214:24: note: in expansion of macro ‘ROS_LOG’ 214 #define ROS_ERROR(...) ROS_LOG(::ros::console::levels::Error, ROSCONSOLE_DEFAULT_NAME, __VA_ARGS__) ^~~ /home/dmz/arena_ws/src/arena-rosnav/utils/misc/path_search/include/path_search/dyn_astar.h:109:3: note: in expansion of macro ‘ROS_ERROR’ 109 ROS_ERROR("Ran out of pool, index=%d %d %d", idx(0), idx(1)); ^~~~~ In file included from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/bspline_optimizer_astar.h:6, from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/intermediate_planner.h:24, from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp:1: /home/dmz/arena_ws/src/arena-rosnav/utils/misc/path_search/include/path_search/dyn_astar.h:109:44: note: format string is defined here 109 ROS_ERROR("Ran out of pool, index=%d %d %d", idx(0), idx(1)); ~^
int

In file included from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/intermediate_planner.h:25, from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp:1: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h: In member function ‘void PolynomialTraj::init()’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:49:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 49 | for (int i = 0; i < times.size(); ++i) | ^~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h: In member function ‘double PolynomialTraj::getLength()’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:185:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<Eigen::Matrix<double, 2, 1> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 185 | for (int i = 1; i < traj_vec2d.size(); ++i) | ^~~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h: In member function ‘double PolynomialTraj::getMeanVel()’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:196:12: warning: unused variable ‘mean_vel’ [-Wunused-variable] 196 | double mean_vel = length / time_sum; | ^~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:197:3: warning: no return statement in function returning non-void [-Wreturn-type] 197 | } | ^ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h: In member function ‘double PolynomialTraj::getAccCost()’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:204:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 204 | for (int s = 0; s < times.size(); ++s) | ^~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h: In member function ‘double PolynomialTraj::getJerk()’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:219:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 219 | for (int s = 0; s < times.size(); ++s) | ^~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h: In member function ‘void PolynomialTraj::getMeanAndMaxVel(double&, double&)’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:251:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 251 | for (int s = 0; s < times.size(); ++s) | ^~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h: In member function ‘void PolynomialTraj::getMeanAndMaxAcc(double&, double&)’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/traj_planner/include/traj_planner/polynomial_traj.h:290:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 290 | for (int s = 0; s < times.size(); ++s) | ^~~~ In file included from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/intermediate_planner.h:28, from /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp:1: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/plan_container_mid.hpp: In member function ‘void GlobalData::getLandmarks(std::vector<Eigen::Matrix<double, 2, 1> >&)’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/plan_container_mid.hpp:172:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 172 | for(int i=0;i<landmarkpoints.size();i++){ | ~^~~~~~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/plan_container_mid.hpp: In member function ‘Eigen::Vector2d GlobalData::getLocalTarget(Eigen::Vector2d&)’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/include/intermediate_planner/plan_container_mid.hpp:188:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 188 | if(id_lastlandmark>=landmarkpoints.size()){ | ~~~^~~~~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp: In member function ‘bool InterPlanner::makeGlobalPlan(plan_msgs::MakeGlobalPlan::Request&, plan_msgs::MakeGlobalPlan::Response&)’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp:178:18: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<Eigen::Matrix<double, 2, 1> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 178 | for(int i=0;i<global_path.size();i++){ | ~^~~~~~~ /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp: In member function ‘bool InterPlanner::optimizePath(double, std::vector<Eigen::Matrix<double, 2, 1> >, std::vector<Eigen::Matrix<double, 2, 1> >, UniformBspline&, InterPlanner::OptimizerType)’: /home/dmz/arena_ws/src/arena-rosnav/utils/ros/rosnodes/intermediate_planner/src/intermediate_planner.cpp:270:21: warning: control reaches end of non-void function [-Wreturn-type] 270 | Eigen::MatrixXd ctrl_pts; | ^~~~ [ 85%] Linking CXX executable /home/dmz/arena_ws/devel/lib/intermediate_planner/intermediate_planner [ 85%] Built target intermediate_planner make: *** [Makefile:141: all] Error 2 Invoking "make -j12 -l12" failed