search

AresMUSH / aresmush

AresMUSH online text-based game server
Other
30 stars 107 forks source link

Add configuration and Github Actions for Rubocop #155

Closed icopp closed 1 year ago

icopp commented 1 year ago

This would add a configuration for the linter/formatter Rubocop that can be used locally in IDEs, plus a Github Actions workflow that would auto-run it on pull requests and automatically commit safe fixes back to PRs (for example: automatically consistent spacing, line breaks, and block delimiters).

The config here uses Rubocop's auto-gen-config functionality to use the extensive default config, but with each specific file that conflicts for a given rule right now disabled. This allows re-enabling rules or files one at a time as desired (by removing the corresponding override in .rubocop_todo.yml) instead of needing to incorporate every fix all at once, while still applying the full rule to any new files.

I know this is out of the blue so don't feel obliged to use it, I just figured I'd toss it up there since it was quick for me to set up.

lynnfaraday commented 1 year ago

Thank you for the contribution. Automatic linting/formatting isn't really something I'm interested in (nothing against Rubocop, just a philosophical thing), but I appreciate you taking the time to submit it.