Arg0s1080
commented
5 years ago Hi @5an1ty !
It seems that Belgium has 3 types of ID Cards:
The first one complies with ICAO specs (Belgian Citizens). The other two (Kids and Foreigners) work as you have explained, so It seems that Belgium is "twisting" the ICAO specifications.
According ICAO 9303-5 (TD1) 4.2.2.1, MRZ chars position will be 6 to 14 in line 1 for document number and 15 for document number hash, so this case is outside the scope of mrz. However, these problems can usually be solved simply by overwriting some property (see issue #3). In this case, overwriting document_number property.
A possible solution could be:
#!/usr/bin/python3
# -*- coding: utf-8 -*-
from mrz.checker.td1 import *
from mrz.base.functions import hash_is_ok
class TD1BELCodeChecker(TD1CodeChecker):
@property
def document_number_hash(self) -> bool:
"""Return True if the hash of the document number is validated, False otherwise."""
if self._document_number_hash == "<":
doc_number_fin = self._optional_data.rstrip("<")
self._document_number = self._document_number + "<" + doc_number_fin[:-1]
self._document_number_hash = doc_number_fin[-1]
return self._report("document number hash", hash_is_ok(self._document_number, self._document_number_hash))Usage:
from mrz.checker.td1_belgian import TD1BELCodeChecker
# CASE 1
code_citizens = ("IDBEL590330101085020100200<<<<\n"
"8502016F0901015BEL<<<<<<<<<<<8\n"
"VAN<DER<VELDEN<<GREET<HILDE<<<")
# CASE 2
mrz_code_kids = ("IDBEL000610035<7017<<<<<<<<<<<\n"
"0002015F0910190BEL000201002003\n"
"MAES<<SOPHIE<ANN<G<<<<<<<<<<<<")
td1_check_citz = TD1BELCodeChecker(code_citizens)
print("CASE 1:%s" % td1_check_citz)
td1_check_kids = TD1BELCodeChecker(mrz_code_kids)
print("CASE 2:%s" % td1_check_kids)
# CASE 3: Let's change document number hash
mrz_code_kids = ("IDBEL000610035<7010<<<<<<<<<<<\n"
"0002015F0910190BEL000201002003\n"
"MAES<<SOPHIE<ANN<G<<<<<<<<<<<<")
td1_check_kids = TD1BELCodeChecker(mrz_code_kids)
print("CASE 3:%s" % td1_check_kids)
print("FALSES CASE 3:")
print(td1_check_kids.report_falses)Output:
CASE 1:True
CASE 2:True
CASE 3:False
FALSES CASE 3:
[('final hash', False), ('document number hash', False)]This solution is valid for the 3 types of Belgian ID Cards. It's a very quick solution, so, I'm sure it can be improved. For example, if you want to report children and foreigners id cards as a warning:
@property
def document_number_hash1(self) -> bool:
"""Return True if the hash of the document number is validated, False otherwise."""
ok = True
if self._document_number_hash == "<":
doc_number_fin = self._optional_data.rstrip("<")
self._document_number = self._document_number + "<" + doc_number_fin[:-1]
self._document_number_hash = doc_number_fin[-1]
self._report("Possible Kids or Foreigners ID Card", kind=1)
ok = not self._compute_warnings
return self._report("document number hash",
ok and hash_is_ok(self._document_number, self._document_number_hash))Output:
CASE 2:True
WARNINGS CASE 2:
['Possible Kid or Foreigner ID Card']I hope I've helped.
Regards.
PS: I'm thinking that maybe it could be a good idea to create a folder to store all these special cases outside of ICAO specs
Removed-5an
imanenter
vamshi-7
typelogic
accensi
Hi there, thank you for making this library!
I have an issue with TD1, specifically scanning Belgian ID cards. If the document_number_hash digit is "<" the document will not verify.
I have checked this with 3 different Belgian ID cards and they all have "<" on index 14 of line 0.
After a ton of googling and reading specs I found an issue with the way you check document_number_hash...
Normally a document number starts at position 5 and ends at position 13 but sometimes a document number exceeds the size of it's slot and optional fields will be used, let's take a look at this example:
IDBEL123456789<1233<<<<<<<<<<<
In this case the document number check is < when we have a scenario like that we need to look at the optional numbers (1233). So when the document number check is < we need to look at the last none empty value: 3. This is the actual hash number. After that we simply verify the hash of:
Document Number: 123456789<123 Hash: 3
And this should verify as True using your verify function.