Open JohnDamilola opened 1 month ago
Here are the new changes added after the last review:
Holistically, this looks very good and quite close.
I left many comments throughout the code, mostly focused on:
Aside from understanding security model, I have no major comments; just the kinds of polish generally needed for a final merge.
Thank you for the contribution.
Hello @bradley-erickson, please help me review this new PR. This one has fewer and only relevant files in it and it now matches the up-to-date code with PMSS being used.
However, I still used a
config.ini
file for the canvas auth configuration details because I needed to automatically update the access token when it expires (after 1hr) and I figured that it was not safe/ideal to update the creds.yaml programmatically.Other than that, I have applied the review comments you made on the previous PR.