ArgLab / ArgLab_writing_observer

Writing Observer and Learning Observer: A system for monitoring learning process data, with an initial focus on writing process data from Google Docs.
GNU Affero General Public License v3.0
3 stars 2 forks source link

Canvas Integration #116

Open JohnDamilola opened 1 month ago

JohnDamilola commented 1 month ago

Hello @bradley-erickson, please help me review this new PR. This one has fewer and only relevant files in it and it now matches the up-to-date code with PMSS being used.

However, I still used a config.ini file for the canvas auth configuration details because I needed to automatically update the access token when it expires (after 1hr) and I figured that it was not safe/ideal to update the creds.yaml programmatically.

Other than that, I have applied the review comments you made on the previous PR.

JohnDamilola commented 1 month ago

Here are the new changes added after the last review:

pmitros commented 3 weeks ago

Holistically, this looks very good and quite close.

I left many comments throughout the code, mostly focused on:

Aside from understanding security model, I have no major comments; just the kinds of polish generally needed for a final merge.

Thank you for the contribution.