search

Argelbargel / gitlab-branch-source-plugin

Jenkins-Plugin to create a multi-branch-project from gitlab
GNU General Public License v2.0
71 stars 44 forks source link

Jenkins.getInstance().getRootUrl() returns null when running jenkins in a docker container with custom javakeystore mapped #100

Closed Sisha1980 closed 4 years ago

Sisha1980 commented 5 years ago

We are running a jenkins master in a docker image using jcasc where if the jenkins base url is not set then the following line will return null, even if the url is derived fine when viewing settings through jenkins UI.

https://github.com/Argelbargel/gitlab-branch-source-plugin/blob/24ce26fd5aeeab1ed25ab73bd3d81d13d99ea82c/src/main/java/argelbargel/jenkins/plugins/gitlab_branch_source/hooks/GitLabSCMWebHookListener.java#L80

seems related to a similar issue on another plugin https://github.com/nishio-dens/bitbucket-pullrequest-builder-plugin/issues/19

The impact is minimal as you won't hit this exception if the url is correctly set in jcasc

Argelbargel commented 4 years ago

Hi. Could you try if the new gitlab-branch-source-plugin (https://plugins.jenkins.io/gitlab-branch-source) fixes this issue? As the company i work for is itself switching to that plugin, i most probably will not make any changes the the code of this plugin (not that i've spent much time on it in the past year in any case :-/)

Sisha1980 commented 4 years ago

Hi

Thanks for the reply, yeah we already switched to that and even contributed I believe.

BR Lars

From: Karsten Kraus notifications@github.com Sent: 3. december 2019 12:29 To: Argelbargel/gitlab-branch-source-plugin gitlab-branch-source-plugin@noreply.github.com Cc: Lars Jakobsen Lars.Jakobsen@3shape.com; Author author@noreply.github.com Subject: Re: [Argelbargel/gitlab-branch-source-plugin] Jenkins.getInstance().getRootUrl() returns null when running jenkins in a docker container with custom javakeystore mapped (#100)

Hi. Could you try if the new gitlab-branch-source-plugin (https://plugins.jenkins.io/gitlab-branch-source) fixes this issue? As the company i work for is itself switching to that plugin, i most probably will not make any changes the the code of this plugin (not that i've spent much time on it in the past year in any case :-/)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Argelbargel/gitlab-branch-source-plugin/issues/100?email_source=notifications&email_token=AFUPTC2OCKW2LJ7A6YBSQVDQWY7I5A5CNFSM4GUVNW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFZB3HY#issuecomment-561126815, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFUPTC5OFZOHZP37YCDFRJDQWY7I5ANCNFSM4GUVNW3Q.