Closed ananace closed 7 years ago
Argelbargel
commented
7 years ago On the contrary. I'm really glad to have someone testing out all the little things that i've missed ;-) I'm just swamped with work right now so i am not sure when i'll get to look into it. Are you using the current 0.7-dev build or the older 0.6.4?
ananace
commented
7 years ago This particular issue is on 0.6.4, probably not going to update it until I've gotten a way to migrate the configuration.
On 29 Jun 2017 12:39 pm, "Karsten Kraus" notifications@github.com wrote:
On the contrary. I'm really glad to have someone testing out all the little things that i've missed ;-) I'm just swamped with work right now so i am not sure when i'll get to look into it. Are you using the current 0.7-dev build or the older 0.6.4?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Argelbargel/gitlab-branch-source-plugin/issues/25#issuecomment-311929107, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgnvE_GloWQD5bAq_kGVPBrFRLrZv6Rks5sI37GgaJpZM4OJAWk .
iamfletch
commented
7 years ago First I want to say thanks to @Argelbargel for this amazing plugin. I am seeing the exact same issue here and I am running 0.6.4.1. @ace13 thanks for posting your work around snippet, saved me loads of time.
awilhelmer
commented
7 years ago I've got a (maybe stupid?) question about the workaround: Should I add these lines in every Jenkinsfile or its enough to have one empty project with a jenkinsfile containing these lines and I execute it when the listeners are lost?
ananace
commented
7 years ago My solution has been to write a meta project that runs and sets the listeners, though I guess you could stick it into an init.groovy.d script too. At least until the bug is fixed.
awilhelmer
commented
7 years ago Okay the listener readd project is working now. Thanks for that. But now all branches of a project are triggered instead of the branch where i pushed the commit.
awilhelmer
commented
7 years ago Found the problem. Two things are wrong:
ACL.impersonate(ACL.SYSTEM, new ListenerInitializerTask()); resolves the problem.public GitLabSCMWebHook() {
manager = new HookManager();
handler = new HookHandler();
new Thread(new Runnable() {
@Override
public void run() {
try {
Thread.sleep(30000);
}
catch (InterruptedException e) {
LOGGER.info("Thread Sleep FAILED!");
}
ACL.impersonate(ACL.SYSTEM, new ListenerInitializerTask());
}
}).start();
}Ah. Ok. I think I've fixed some of it (ACL) in 0.7. But I'll have another look and fix it in 0.6.x too
Argelbargel
commented
7 years ago Jup. Was already fixed in 0.7-dev. Backported the changes to 0.6.4.2. Please give it a try and shout if it still does not work as expected...
ananace
commented
7 years ago The issue does seems to be fixed on 0.6.4.2, haven't needed to re-add any listeners even after restarting Jenkins multiple times.
Thanks.
Argelbargel
commented
7 years ago Ok. Then i'll close this. Thank you, guys!
Ran into a new issue with our production Jenkins today where no listeners ended up being registered. This led to issues with all GitLab webhook calls resulting in 404 responses.
Jenkins version is 2.67 And if it helps, plugins and versions;
Managed to debug the symptom down to;
Ended up manually adding a listener for the root as a temporary solution;
No idea about the cause, and the startup log doesn't give much information either;
(Final messages are from me logging in and manually launching a project scan.)
Hope you're not sick of all my issues yet.