search

Argelbargel / vault-raft-snapshot-agent

An agent which creates periodic snapshots of Vault's integrated raft storage and stores them locally or in remote storages as backup in case of system failure or user errors.
MIT License
8 stars 3 forks source link

Fix bug in snapshot-agent.go #31

Closed silverwinter313 closed 2 months ago

silverwinter313 commented 2 months ago

Hi, we want to use your fork, but in code have bug in line. When call UploadSnapshot, set zero bytes and after sent empty file in s3. I make change and solved own problem. Can are you review fix?

Argelbargel commented 2 months ago

Hi @silverwinter313 ,

thank you so very much! As i created this fork mainly to add some Things i missed in the original but had no real use case besides local storage, i had no was really to test my additions. Exactly the problem you found ist the one i saw when using the s3 storage but i did not have the time to Look into it...

Argelbargel commented 2 months ago

Oh, sorry just remembered that i'll have to tag a release for us to use the bugfix. Will do that this week, promised!

silverwinter313 commented 2 months ago

Thanks a lot, I wait new release with hot fix!

Argelbargel commented 2 months ago

HI @silverwinter313, Release 0.10.11 contains your bugfix. Binaries, Images and Helm-Charts should by uptodate by now...