search

ArgoCanada / argoFloats

Tools for analyzing collections of oceanographic Argo floats
https://argocanada.github.io/argoFloats/index.html
17 stars 7 forks source link

Should undo or "u" remove the pasted hover message in mapApp() #524

Closed j-harbin closed 3 years ago

j-harbin commented 3 years ago

Dan pointed out that currently in mapApp() if a user does the following, for example:

  1. Click "h" to paste a hover message
  2. Zoom in
  3. Clicks "u" or "Undo"

Not only does the app Zoom out, it also removes the hover message. Dan voted a 0.5 to keep it this way. To me, as a user, I would expect "u" or Undo to ONLY undo the last thing I did. Meaning if I did the above three steps, the "u" would only zoom out the area and I would need to click "u" again to remove my pasted hover message.

dankelley commented 3 years ago

Um, so is this changing or not?

dankelley commented 3 years ago

Also, who is assigned? (I'm hoping the ans is @j-harbin)

j-harbin commented 3 years ago

I'll be honest, I don't know what to do with this because we've voted opposite haha!

j-harbin commented 3 years ago

done in commit 721c96566ca7cf065707b6465d8af02de3dfe301 of develop.