search

ArgoCanada / argoFloats

Tools for analyzing collections of oceanographic Argo floats
https://argocanada.github.io/argoFloats/index.html
17 stars 7 forks source link

PROPOSAL: Add ID and cycle to the index #532

Closed j-harbin closed 2 years ago

j-harbin commented 2 years ago

Currently the names of an index include: file , date, latitude, longitude, ocean, profiler_type, institution, and date_update. @dankelley and I were discussing that I should add ID and cycle to this data frame so it will speed up the process of extracting ID and cycle. See below the time difference if ID and cycle were included in the index.

library(argoFloats)
ai <- getIndex()
A <- system.time(ai[["ID"]],1)
A
#>    user  system elapsed 
#>   2.303   0.013   2.324
B <- system.time(ai[["file"]],1)
B
#>    user  system elapsed 
#>       0       0       0

Created on 2021-11-04 by the reprex package (v2.0.0)

dankelley commented 2 years ago

But here's the good thing...

> round(log(10),3)
[1] 2.303

🐵

dankelley commented 2 years ago

@j-harbin where do we sand on this? I sort of think it was done 28 days ago but, if not, perhaps you can find time to do it, so the issue can be closed.

j-harbin commented 2 years ago

Thanks for commenting to avoid the stale bot message. This has not been done yet, but again is on my radar of list of things to do.

github-actions[bot] commented 2 years ago

The Stale-bot has marked this issue as Stale, because no new comments have been added in the past 30 days. Unless a comment is added within the next 7 days, the Stale-bot will close the issue. The purpose of these automated actions is to prevent the developers from forgetting about unattended tasks. Note that adding a "pinned" label will turn this action off for a given issue.