ArgoCanada / argoFloats

Tools for analyzing collections of oceanographic Argo floats
https://argocanada.github.io/argoFloats/index.html
17 stars 7 forks source link

need to update on CRAN #543

Closed dankelley closed 2 years ago

dankelley commented 2 years ago

Please see https://github.com/dankelley/oce/issues/1918 for details. CRAN is telling us to update argoFloats. I will do this before the end of the week. Once I've done what I need to do, I'll ask @j-harbin to do a test build. (I will do oce first, and that will involve running both local and nonlocal tests. That process will take a few hours.)

dankelley commented 2 years ago

@j-harbin I have done local tests, and have submitted a remote test on windows. This is for "develop" commit 7669b9eb0261f8c58df3330839635f57fe646357.

Can you do a quick test build/check on your machine? (Also, please "follow" this comment thread so you can keep up with my other tests.). I may need to ask you to test several times. I'd love to clear this up today so I can submit to CRAN before noon tomorrow. (I like to try to submit to CRAN during the week, in case one of the CRAN volunteers has to look at test results.)

j-harbin commented 2 years ago

Screen Shot 2022-02-17 at 8 18 46 AM

All good so far!

dankelley commented 2 years ago

Excellent. I've merged into "main" now (commit 17c1c95d7425efe0dc5c2858d66189e101702790), so please hop over there and do local build/check and post results. (You might want to make a checklist like I have below.)

DK checklist

Links for check_win*:

j-harbin commented 2 years ago

JH Checklist:

dankelley commented 2 years ago

Submitted. Details of the email, below. I will leave this issue open until I see it appearing on CRAN for some of the checked systems (see https://cran.r-project.org/web/checks/check_results_argoFloats.html). I won't wait for all systems because sometimes that takes a week or two.

Dear maintainer,

thanks, package argoFloats_1.0.4.tar.gz is on its way to CRAN.

Best regards, CRAN teams' auto-check service Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64 Check: CRAN incoming feasibility, Result: Note_to_CRAN_maintainers Maintainer: 'Dan Kelley [dan.kelley@dal.ca](mailto:dan.kelley@dal.ca)'

dankelley commented 2 years ago

I'm closing this now, since the following two links show that CRAN Downloads and Checks are all now updated to this version.