search

ArgoCanada / argoFloats

Tools for analyzing collections of oceanographic Argo floats
https://argocanada.github.io/argoFloats/index.html
17 stars 7 forks source link

getProfileFromUrl() doc error #575

Closed dankelley closed 2 years ago

dankelley commented 2 years ago

It says that for a missing file, NULL is returned. However, NA is returned. I propose changing the docs, not the code, because somebody might have written code that is based on the actual behaviour, not the documented behaviour.

Do you agree with my decision, @j-harbin? If so, I'll make the change. (The change is quicker than typing this issue, by orders of magnitude!)

Screen Shot 2022-05-31 at 3 15 39 PM
j-harbin commented 2 years ago

Done in commit ad24fd27d6d6d4cf30958c4ea26ad667caa0ef18 of develop. @dankelley if you are satisfied with the changes feel free to close the issue.

dankelley commented 2 years ago

Looks great, thanks!