search

Argonne-National-Laboratory / neml

Modular consitutive modeling library for structural materials
Other
10 stars 21 forks source link

Added functionality to damage model #135

Closed maxnezdyur closed 2 years ago

maxnezdyur commented 2 years ago

These functions will help make it easier to work with the damage models with MOOSE. Including a function to get the damage value from the history array. While we know currently it is the first element in the array, a function to get the damage is useful in case that location changes.

reverendbedford commented 2 years ago

Whoops, nevermind you setup the PR on #133. I'll take a look before I merge in the other one.

maxnezdyur commented 2 years ago

Thank you, I tried to keep up with any coding conventions that you had. Let me know if there is any other way to do things. I know that in one of the issues you wanted to implement a better way to pass the state. If that gets accomplished then it would make the function get_damage redundant.

reverendbedford commented 2 years ago

I will update the get_damage method once I move everything over to labeled history.

maxnezdyur commented 2 years ago

We currently have the same class that would handle NEML stress, whether it is a damage model or not. That function gives us a way to determine if the model is a damage model or not without having to parse it from the XML file. It is useful in case the XML file naming conventions change. We don't want a regular NEML model trying to store the damage when it is not needed.

reverendbedford commented 2 years ago

Okay, I'll merge it into the other PR, which is ready to merge into dev. Should be done in 30 minutes or so.