search

Argyle-Software / kyber

A rust implementation of the Kyber post-quantum KEM
https://docs.rs/pqc_kyber/
Apache License 2.0
163 stars 37 forks source link

Add `no_std` build test on target with no std #103

Closed pinkforest closed 7 months ago

pinkforest commented 9 months ago

We use the same in curve25519-dalek

I have a solution for the non-exclusive features.. will send a PR after this

mberry commented 9 months ago

Please raise an issue that we can discuss.

mberry commented 9 months ago

I've reopened this and happy to discuss it, but there's a lot of work needed and I won't get your hopes up on it getting merged in this state.

As it stands, all the CI tests run without the standard library already, that includes all the cross compilation across dozens of platforms in cross.yaml, there's future intentions to add std as a default feature soon, at which point we will need no_std tests, hopefully we can find a more appropriate cross-platform PR to work with here?

I see no need to pull in cargo-hack or dtolnays custom action to achieve such things, am not casting aspersions on them, simply aiming for coherence across this repo, including in CI, and that means using actions-rs and cargo build like all the other scripts here, hope you understand :)

mberry commented 9 months ago

You can find the failure points here to fix the failing CI: https://github.com/Argyle-Software/kyber/actions/runs/6371429053/job/17293370086

mberry commented 7 months ago

Closing this, hopefully we can get another contribution here because am quite certain you are good at these things. Can contact me anytime at foss{aaa]mitchellberry.com