search

Argyle-Software / kyber

A rust implementation of the Kyber post-quantum KEM
https://docs.rs/pqc_kyber/
Apache License 2.0
178 stars 40 forks source link

References to kyber 764 which is not a standard #3

Closed ETKNeil closed 2 years ago

ETKNeil commented 2 years ago 
./Cargo.toml:# Defaults to "kyber764" if none selected
./readme.md:See the [**features**](#features) section for different options regarding security levels and modes of operation. The default security setting is kyber764.
./readme.md:If no security level is specified then kyber764 is used by default as recommended by the authors. It is roughly equivalent to AES-196.  Apart from the two security levels, all other features can be combined as needed. For example:
./src/avx2/indcpa.rs:  #[cfg(not(any(feature="kyber1024", feature="kyber512", feature="90s")))] // kyber764 
./src/avx2/indcpa.rs:    #[cfg(not(any(feature="kyber1024", feature="kyber512", feature="90s")))] // kyber764)
./src/lib.rs://! If no security level is set then Kyber764 is used, this is roughly equivalent to AES-196. See below for setting other levels. 
./tests/run_all_tests.sh:announce "Kyber764"
./tests/run_all_tests.sh:announce "Kyber764-90s"
./tests/run_all_tests.sh:announce "Reference Kyber764"
./tests/run_all_tests.sh:announce "Reference Kyber764-90s"
./tests/run_all_tests.sh:announce "Kyber764 KATs"
./tests/run_all_tests.sh:announce "Kyber764-90s KATs"
./tests/run_all_tests.sh:announce "Reference Kyber764 KATs"
./tests/run_all_tests.sh:announce "Reference Kyber764-90s KATs"

Please change those strings to 768 which is the actual standard (and which you actually implemented