Argyle-Software / kyber

A rust implementation of the Kyber post-quantum KEM
https://docs.rs/pqc_kyber/
Apache License 2.0
164 stars 37 forks source link

Expose INDCPA-KYBER primitives #36

Closed tbrezot closed 1 year ago

tbrezot commented 1 year ago

This MR exposes the INDCPA-KYBER primitives:

mberry commented 1 year ago

Hey, thanks for the PR.

Exposed inner api functionality did actually exist recently to run the test vectors. That was replaced with rust config flags.

I'm fine to expose them, but my main concern with this merge is the sheer number of lines due to the formatting changes, would it be possible to separate out exposing the primitives and formatting into different PR's?

I hear you on the rustfmt matter and it's certainly an outstanding matter to fix, more likely integrate it into CI.

Also would prefer to name the feature hazmat if that's ok, indcpa implies security, whereas hazmat is commonly used to indicate dangerous api's.

Thanks again.

tbrezot commented 1 year ago

Hey, I removed the formatting changes and renamed the feature to hazmat. I didn't know this practice, thanks for the explanation.

Is it good for you now ?

mberry commented 1 year ago

Looks great Théophile, thanks. I will merge sometime tomorrow Sydney time and get the crate updated. Cheers.

tbrezot commented 1 year ago

Great, thanks a lot!