Argyle-Software / kyber

A rust implementation of the Kyber post-quantum KEM
https://docs.rs/pqc_kyber/
Apache License 2.0
164 stars 37 forks source link

Implement the standard library Error trait when "std" is enabled #47

Closed faern closed 1 year ago

faern commented 1 year ago

Without having this trait implemented, a lot of existing error handling code will refuse to work with this type.

My current use case is I have an error that encapsulates KyberError and I want to be able to return it from my own std::error::Error::source implementation. But I can't, because the signature for that method requires the source to of course also implement std::error::Error.

mberry commented 1 year ago

The macOS test runner has a random lottery failure mode, all good on re-run.