Add error handling for `HttpError: Validation Failed: "message":"body is too long (maximum is 65536 characters)"}` - Githubissues

AriPerkkio / eslint-remote-tester-run-action

Github action for running eslint-remote-tester and receiving results in Github issue

1 stars 1 forks source link

Add error handling for `HttpError: Validation Failed: "message":"body is too long (maximum is 65536 characters)"}` #26

Closed AriPerkkio closed 2 years ago

AriPerkkio commented 2 years ago

Prevent GithubClient from attempting to post +65k character long messages. A simple String.slice might not be enough since we don't want to break formatting of markdown.

https://github.com/AriPerkkio/eslint-remote-tester-run-action/blob/e3e6fa1786f7cd45aaf3a2453fc4e7c8559eb041/src/github-client.ts#L46-L50

There is already some result limitation in place:

Count of results are limited by max-result-count configuration option.

https://github.com/AriPerkkio/eslint-remote-tester-run-action/blob/e3e6fa1786f7cd45aaf3a2453fc4e7c8559eb041/src/comment-templates.ts#L40

eslint-remote-tester truncates rows with +1000 characters: https://github.com/AriPerkkio/eslint-remote-tester/blob/bee1286e169ab37a3ec526fbdf60ce66473b1917/lib/engine/worker-task.ts#L134.

References https://github.com/jsx-eslint/eslint-plugin-react/issues/3327