search

AriPerkkio / eslint-remote-tester

CLI tool for testing given ESlint rules against multiple repositories at once.
https://www.npmjs.com/package/eslint-remote-tester
129 stars 11 forks source link

Weekly scheduled smoke test: eslint-plugin-lit #410

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Detected 3 ESLint reports and/or crashes. Scanned 5817 repositories.

Rules:

Click to expand ## Rule: lit/value-after-constraints - Message: `Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-create-group-dialog/gr-create-group-dialog.ts:51 Rule: "lit/value-after-constraints"` - Path: `qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-create-group-dialog/gr-create-group-dialog.ts` - [Link](https://github.com/qtqa/gerrit/blob/HEAD/polygerrit-ui/app/elements/admin/gr-create-group-dialog/gr-create-group-dialog.ts#L51) ```ts 49 | 50 | override render() { > 51 | return html` 52 |
53 |
54 |
``` ``` TypeError: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-create-group-dialog/gr-create-group-dialog.ts:51 Rule: "lit/value-after-constraints" at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54) at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () ``` ## Rule: lit/value-after-constraints - Message: `Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.ts:236 Rule: "lit/value-after-constraints"` - Path: `qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.ts` - [Link](https://github.com/qtqa/gerrit/blob/HEAD/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.ts#L236) ```ts 234 | 235 | private renderItemList(item: BranchInfo | TagInfo, index: number) { > 236 | return html` 237 | 238 | 239 | ``` ``` TypeError: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.ts:236 Rule: "lit/value-after-constraints" at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54) at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () ``` ## Rule: lit/value-after-constraints - Message: `Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/adobe/spectrum-web-components/packages/overlay/test/overlay.test.ts:345 Rule: "lit/value-after-constraints"` - Path: `adobe/spectrum-web-components/packages/overlay/test/overlay.test.ts` - [Link](https://github.com/adobe/spectrum-web-components/blob/HEAD/packages/overlay/test/overlay.test.ts#L345) ```ts 343 | 344 | it('closes an inline overlay when tabbing past the content', async () => { > 345 | const el = await fixture(html` 346 |
347 | Trigger 348 |
``` ``` TypeError: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/adobe/spectrum-web-components/packages/overlay/test/overlay.test.ts:345 Rule: "lit/value-after-constraints" at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54) at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30) at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25 at Array.forEach () ```
AriPerkkio commented 1 year ago

First crash of eslint-plugin-lit 😮

cc @43081j if you are interested, likely related to https://github.com/43081j/eslint-plugin-lit/pull/145.

43081j commented 1 year ago

well that's a fun one isn't it :D

looks like somehow the attribute locations are nullish in your run. im not sure how that's possible 🤔

we can pretty easily account for that (which i may do anyway to be safe), but you shouldn't usually be able to end up in this situation... since source locations are generally always enabled. curious how it managed to do that

github-actions[bot] commented 1 year ago

Detected 9 ESLint reports and/or crashes. Scanned 6223 repositories.

Rules:

Click to expand ## Rule: lit/value-after-constraints - Message: `Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/js-works/js-cockpit/src/main/components/side-menu2/side-menu2.ts:49 Rule: "lit/value-after-constraints"` - Path: `js-works/js-cockpit/src/main/components/side-menu2/side-menu2.ts` - [Link](https://github.com/js-works/js-cockpit/blob/HEAD/src/main/components/side-menu2/side-menu2.ts#L49) ```ts 47 | }, 4000); 48 | > 49 | return html` 50 |
51 |