AriTheElk / sublimetext-defaultplus-theme

A beautifully simplistic sublime text theme.
87 stars 19 forks source link

Sublime Text 3 Support #2

Closed caze73 closed 9 years ago

caze73 commented 10 years ago

I've tried to use your theme in Sublime Text 3 but there are some strange color effects in the tab and status bar. Do you plan to create a working version?

Thanks, Carsten

bildschirmfoto 2013-12-04 um 22 06 12

AriTheElk commented 10 years ago

It currently has some bugs in ST3, but I do plan on adding support for it sometime this week.

caze73 commented 10 years ago

Sounds good, thanks for your fast reply.

AriTheElk commented 10 years ago

Hmm, after a bit of testing, I can't recreate the exact bug you're experiencing.. You installed it correctly, right? The color glitches occur when it can't find images from the theme. You didn't delete the assets folder, did you?

caze73 commented 10 years ago

No, didn't delete or modify anything. I did another try with a new git clone, same result. I have a retina Mac, could this be the problem? I attach another screenshot from the complete window. If you give me some hints, I could do some tests for you if it helps.

screenshot

AriTheElk commented 10 years ago

Ah! That explains it, my theme doesn't support retina graphics. I'll push retina graphics to the repo later today

wilfredjonathanjames commented 10 years ago

Also waiting for this fix!

caze73 commented 10 years ago

Any news on this?

AriTheElk commented 10 years ago

I'm sorry, my free time over the holidays has been super limited. I'm working on converting all the graphics to retina, but it's taking a lot longer than I anticipated since I'm creating the vectors from scratch. I'll put up a beta branch so you guys can test it while I'm still adding support for all the icons in the application.

AriTheElk commented 10 years ago

Hello everyone, so sorry for the long delay. I've started maintaing a separate branch called retina. You can pull from that branch if you wish to test out the retina support. I still haven't converted 100% of the assets to retina, as I've been busy. However that should at least give you a taste of what's to come.

If you'd like, you're also more than welcome to fill in the gaps if there's any missing icons that need to be converted to retina. That would be a huge help to the project.

Thanks for you patience!

blurmonk commented 10 years ago

Hi

I am on Linux and I still get this exact problem even with the retina branch

igitur commented 10 years ago

Also on Linux, tried both master and retina branches and get same problem. Does anyone know the cause? Image transparency or something?

AriTheElk commented 9 years ago

Hello everybody. I've launched a new branch (v2) which houses all the new changes. This new branch should fix a number of issues, including this one. Try it out and lemme know if your issues are resolved :smile:

As this is still just a beta release, it doesn't include the theme options yet, but they are coming.

caze73 commented 9 years ago

There are still some small issues left:

screenshot

Or have I missed something?

AriTheElk commented 9 years ago

I don't understand how... you're on a Retina mac? You can install other themes, and they work fine? Going to look through my files again to see if anything could have gotten messed up.

AriTheElk commented 9 years ago

And you did clone the repo into the directory named "Theme - DefaultPlus" right? That's the only thing I can imagine that could be happening.

caze73 commented 9 years ago

Yes, I'm on a Retina Mac. I'm using Sublime Text 3, Build 3083. I've clone the master branch into a folder "Theme - DefaultPlus" into "~/Library/Application Support/Sublime Text 3/Packages/User". Any other information I can help you with?

AriTheElk commented 9 years ago

Hmm.. All the screenshots seen in the readme are taken from Sublime Text 3, Build 3083. Only difference is I'm on a retina mac.

So just to be clear, the path ~/Library/Application Support/Sublime Text 3/Packages/Theme - DefaultPlus/DefaultPlus/ is the directory that the .pngassets are located in? I'm scratching my head trying to figure out why they wouldn't be loading. Hopefully I won't have to worry about problems like this when I get it in package control.

caze73 commented 9 years ago

Yeap, everything is in this directory. Do you know an other theme which I could possible test?

caze73 commented 9 years ago

Wait, I've got it. My fault. I've checked out into the folder "~/Library/Application Support/Sublime Text 3/Packages/User", but correct is "~/Library/Application Support/Sublime Text 3/Packages". Then everything looks fine. Thanks for your support.

AriTheElk commented 9 years ago

:+1: good to hear