search

AriaMinaei / pretty-error

See node.js errors with less clutter
MIT License
1.52k stars 49 forks source link

Typescript definition file please? #31

Closed radarsu closed 7 years ago

radarsu commented 8 years ago

Could you please make typescript definitions file for pretty-error and send em to DefinitelyTyped project?

It shouldn't be a big deal, just for consistency. https://github.com/DefinitelyTyped/DefinitelyTyped/

AriaMinaei commented 8 years ago

Yes, TS definitions would be nice. You're welcome to submit a PR.

ezintz commented 7 years ago

Would anyone mind publishing a new version with the updated typings? Currently I got the following error while trying to compile my source:

node_modules/pretty-error/index.d.ts(4,18): error TS7010: 'start', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/pretty-error/index.d.ts(5,18): error TS7010: 'stop', which lacks return-type annotation, implicitly has an 'any' return type.

I had a look on the master branch where everything seems to be OK, meaning tsc would not exit with this error. My fix for now, since I also have to do it for another package, create a post installation script which fixes it (yes, I know it is ugly thats why I am pushing this issue ;) )

sed -i -e 's/function start();/function start():PrettyError;/g' ./node_modules/pretty-error/index.d.ts
sed -i -e "s/function stop();/function stop():any;/g" ./node_modules/pretty-error/index.d.ts
AriaMinaei commented 7 years ago

@ezintz aah looks like I forgot to publish to npm that last commit. I'll do that now :)