AriaMinaei / pretty-error

See node.js errors with less clutter

MIT License

1.52k stars 48 forks source link

Bug Fix: Error message is stripped if stack exists #49

Closed nickmaltsev closed 7 years ago

nickmaltsev commented 7 years ago

32

AriaMinaei commented 7 years ago

Thanks for the PR! Could you check why the build fails? Also, let's add one or more test cases for this specific case. I'm reviewing this on mobile, but first glance tells me that the this code may not be able to handle multi line messages, but I'm not sure

nickmaltsev commented 7 years ago

@AriaMinaei resolve test issues, add multiline test case

AriaMinaei commented 7 years ago

Great! Allow me to test this on Thursday and publish to npm by then :)

AriaMinaei commented 7 years ago

Published as RC

alexparish commented 6 years ago

@AriaMinaei I see the RC was published some time ago. Is this ready for a 2.2.0 release?

AriaMinaei commented 6 years ago

Yeah this has been left unmerged for a long time. Sorry about that :)

I just added a line in the readme asking people to try out the RC.