search

AriaMinaei / pretty-error

See node.js errors with less clutter
MIT License
1.52k stars 48 forks source link

Add bootstrap_node.js to list of internal libraries #50

Open mhkeller opened 6 years ago

mhkeller commented 6 years ago

As found here: https://github.com/nodejs/node/blob/e6dfd59be02c329228c050ad904e1eb046ff379f/lib/internal/bootstrap_node.js

AriaMinaei commented 6 years ago

PRs welcome :)

mhkeller commented 6 years ago

Sure thing. While I'm at it, should I also add any missing files that I come across in internal/**/*?

AriaMinaei commented 6 years ago

Yeah that's a good idea!

mhkeller commented 6 years ago

I tried looking in the source but I'm not great at coffeescript -- how are you handling sub-directory paths?

For instance, should a file like types.js be included in this list as util/types.js, /util/types.js or maybe just types.js?

AriaMinaei commented 6 years ago

utils/types.js should work.

floxcristian commented 5 years ago

How do you skip bootstrap errors? I tried: pe.skipPackage('bootstrap_node'); and pe.skipPath('internal/**/*'); but that did not work

AriaMinaei commented 5 years ago

@cristianfloresee how does the error normally show up in the stack trace? Could you paste a screenshot here?