search

Ariadne-CMS / arc-base

ARC: base types for all components
http://ariadne-cms.github.io/arc/
Other
1 stars 3 forks source link

change behaviour of the parents call #29

Closed mjrider closed 8 years ago

mjrider commented 8 years ago

currently parents gives strange results parents('/somepath/','/somepath/sub/') would result in ['/somepath/sub/'] This is unexpected, because the root is not a parent of path

parents('/somepath/','/otherpath/') would result in['/otherpath/'] This is unexpected, because the root is not a parent of path

new behaviour would be in both cases an []

other change, which can be split in a separate pull is the change in used assert functions

codecov-io commented 8 years ago

Current coverage is 73.04%

Merging #29 into master will increase coverage by +0.20% as of 01f07f9

@@            master     #29   diff @@
======================================
  Files           10      10       
  Stmts          534     538     +4
  Branches         0       0       
  Methods         95      95       
======================================
+ Hit            389     393     +4
  Partial          0       0       
  Missed         145     145

Review entire Coverage Diff as of 01f07f9

Powered by Codecov. Updated on successful CI builds.

scrutinizer-notifier commented 8 years ago

The inspection completed: 1 new issues, 1 updated code elements