Shizuku support possible?

Arian04 / android-hid-client

Android app that allows you to use your phone as a keyboard and mouse WITHOUT any software on the other end (Requires root)

GNU General Public License v3.0

109 stars 4 forks source link

Shizuku support possible? #17

Closed Steve-Brule closed 2 months ago

Steve-Brule commented 3 months ago

Hi! I always dreamed of an app like this, but sadly can't root my phone.

Is this app able to function with ADB permissions? If so, it'd be amazing to see shizuku support implemented.

Arian04 commented 3 months ago

hmm. I have some ideas on how i might be able to get it working but it depends on how much Shizuku lets me do. I could maybe see if I could add HID functions to the default android gadget but I haven't checked if that would work without root or even at all

Arian04 commented 3 months ago

thanks so much for this! I'm not too sure if it's possible to add Shizuku support (still looking into it), but either way, your request made me think about doing things differently, and now I got my HID functions working with the standard gadget, which simplifies so much!! Now, the standard Android gadget shouldn't have to be disabled at all once I fully implement this. It simplifies SOOO much.

closed 3 issues due to this simplification in 63549986fdc0a879a5e1c8e05ebda153f46c45b0

Steve-Brule commented 3 months ago

Haven't really done anything, but you're welcome regardless :)

Arian04 commented 3 months ago

So after the simplification, my app only uses root in these places

Adding HID functions to the default Android USB gadget (I think I only need system permissions for this though)
Setting /dev/hidg0//dev/hidg1 file mode permissions, SELinux context, and adding an SELinux policy (I don't think I can do this without root, BUT maybe I can find a way for it to not be necessary)
Grabbing debug logs (unnecessary, wasn't considering non-root users when I wrote it)

So basically, I might be able to get it working if I can get system permissions. I'll try to look into this further sometime soon.

Arian04 commented 2 months ago

as far as I can tell, this is not possible :(

if anyone thinks I'm wrong about that or something changes that makes it so this could be possible in the future, feel free to reply under this issue and i'll consider re-opening it. Like I said, I don't use root in very many spots for this app, so if this becomes possible to do without root, code-wise, it should be an incredibly simple change.