search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
56 stars 52 forks source link

App.config/settings compatibility #1

Closed nblumhardt closed 9 years ago

nblumhardt commented 9 years ago

https://github.com/sonicjolt/serilog-sinks-rabbitmq/blob/master/src/Serilog.Sink.RabbitMq/LoggerConfigurationRabbitMqExtension.cs#L21

Serilog's app settings support needs an overload of this method that accepts each parameter individually.

madslyng commented 9 years ago

I'm not sure how to fix this. It sounds like something that needs to be done in the Serilog repo ?

What can I do to solve it ?

nblumhardt commented 9 years ago

No, fixing it just entails adding an extra method in LoggerConfigurationRabbitMQExtension that accepts individual parameters instead of the one big configuration object. If you have a look at e.g. the MongoDB sink you'll see this pattern in action.

madslyng commented 9 years ago

Added overload of Extension method.

Believe this fixes the issue