search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Upgrade RabbitMQ client to 6.0 #108

Closed Samuron closed 4 years ago

Samuron commented 4 years ago

Hi guys!

Thank you for your awesome work. We are using Rabbitmq in our project and I've tried to upgrade the client version, but latest prerelease is not compatible with the sink. I've tried to come up with the PR to fix the issues. Unfortunately it requires some breaking changes to your library as well. I can try to mitigate them (i.e. do not change Heartbeat to TimeSpan and leave Protocol but do not use it), but still it will require the bump of netstandard version to 2.0 and .NET Framework to 4.6.1. Which should not be very big deal as lower version are pretty much deprecated for quite some time.

Fixes #102

madslyng commented 4 years ago

Thanks for the PR, I'll look into it as soon as I can.

niwrA commented 4 years ago

I think my change for handling the timespan is probably more elegant - just creating a TimeSpan from the heartbeat's milliseconds only in the one place that is needed results in just that one line changed to support this. And all existing configurations will remain compatible in my version.