ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Added Support to Specify ClientProvidedName #120

Closed mustafacagataytulun closed 5 months ago

mustafacagataytulun commented 2 years ago

ClientProvidedName is a special field in RabbitMQ.Client to specify a client name to differentiate between connected applications in RabbitMQ Management UI. In this PR, I add support to fill this property.

This is the UI without providing ClientProvidedName (current behavior):

image

This is the UI with providing ClientProvidedName:

image

Users of the library can specify their ClientProvidedName with configuration:

image

If this property is null or whitespace, the library will continue to work as is. So, current users can continue to work without any extra configuration. I mean, there is no breaking change.

lyng-dev commented 2 years ago

@mustafacagataytulun I'm not currently maintaining the library. But if I get some time, I will release an update.

Thanks for your contribution!

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sungam3r commented 5 months ago

Can be closed.

ArieGato commented 5 months ago

Has been replaced by #120