ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
56 stars 53 forks source link

'Require conversation resolution before merging' option is too strict #136

Closed sungam3r closed 9 months ago

sungam3r commented 9 months ago

I have never seen before that someone have used that option изображение

It's too strict and prevent pipeline from run even for my own comments. I suggest to disable option.

ArieGato commented 9 months ago

It's something I'm used to work with in azure devops. This ensures that all comments are processed. How does this prevent pipelines from running?

sungam3r commented 9 months ago

I mean it prevents from merging in case of any comment, even informational one. Up to you.

ArieGato commented 9 months ago

Okay, I’ll try it without resolution of comments. Let’s see how it works out.