search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
56 stars 53 forks source link

Updated Docker integration tests. #137

Closed Pastafarian closed 9 months ago

Pastafarian commented 9 months ago

Tried running the docker integration tests after pulling the project down to take a closer look, found out they weren't currently working so thought I'd get them updated and passing again.

Good to see all the recent work on the project!

Updated definitions.json to make the username and password consistent with the integration tests.

Updated images from microsoft/dotnet:2.2-sdk to mcr.microsoft.com/dotnet/sdk:8.0 and rabbitmq:3-management to rabbitmq:3.12.12-management.

Removed net472 as a Framework as it prevents projects from running in a Linux container. Given netstandard2.0 is supported, it's superfluous.

ArieGato commented 9 months ago

Thnx for the contribution.

I would really like to keep the integration tests for the AppSettings support though. Any ideas how we can handle this?

Pastafarian commented 9 months ago

Yes, it's a bit of a pain, but it's possible by runnng the integration tests from a mono container that supports the .NET Framework, then install .NET 6.0 and 8.0 into that container.

A bit of a faff it turns out. But we do now have a version that multi-targets and now runs the previously removed config tests.

PR updated!

Pastafarian commented 9 months ago

Added RabbitMQCollection.cs in an attempt to fix tests before your update to main made it redundent, now removed. Reverted changes to Serilog.Sinks.RabbitMQ.Tests.Integration.csproj and ConfigurationExtensionsFixture.cs