Add API approval tests - Githubissues

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq

Apache License 2.0

53 stars 51 forks source link

Add API approval tests #144

Closed sungam3r closed 6 months ago

sungam3r commented 6 months ago

fixes #141

sungam3r commented 6 months ago

For now I see

If I understand correctly pipeline has not even started because of review settings. So I have no change to fix errors if any - I just don't see them. So I should wait for review. If you are concerned about security, then it is not necessary to require a review. Nobody can just merge change into the repository. Only those who have write access can - owners, collaborators, etc.

sungam3r commented 6 months ago

@ArieGato I resolved conflicts.

ArieGato commented 6 months ago

@sungam3r There are some conflicts

sungam3r commented 6 months ago

Done.