search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Simplify versioning #145

Closed sungam3r closed 5 months ago

sungam3r commented 6 months ago

See https://github.com/ArieGato/serilog-sinks-rabbitmq/pull/142/files#r1478184786

ArieGato commented 6 months ago

@sungam3r can the versioning be simplefied without gitversion?

sungam3r commented 6 months ago

Yes. MinVer package can handle versioning. See this one https://github.com/destructurama/by-ignoring/blob/master/src/Directory.Build.props#L35 and then https://github.com/destructurama/by-ignoring/blob/master/.github/workflows/publish-release.yml - there is no any jumping around versioning like here https://github.com/ArieGato/serilog-sinks-rabbitmq/blob/master/.github/workflows/publish-release.yml#L55-L72

ArieGato commented 6 months ago

Sounds good.