search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Migrate to Shouldly #150

Closed sungam3r closed 6 months ago

sungam3r commented 6 months ago

fixes #149

@ArieGato I will retarget PR after merging #144.

sungam3r commented 6 months ago

I merged changes from master. I would like to note that I'm still do not see workflow running. It confuses and prevents from fixing bugs with CI.

ArieGato commented 6 months ago

@sungam3r what can I do to make the ci build fire for you?

sungam3r commented 6 months ago

I think this is because the rule requiring review. Just try to disable it.

ArieGato commented 6 months ago

I think the ci build is missing: on pull_request

sungam3r commented 6 months ago

Right. I have not reviewed workflow files yet.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (54d6292) 96.55% compared to head (5a0466e) 96.55%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #150 +/- ## ======================================= Coverage 96.55% 96.55% ======================================= Files 8 8 Lines 348 348 Branches 41 41 ======================================= Hits 336 336 Misses 5 5 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.