search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

ci build fails on Approval check #151

Closed ArieGato closed 6 months ago

ArieGato commented 6 months ago

The ci build fails on the public API approval test.

~It appears to be caused by the release configuration build?~

[xUnit.net 00:00:01.85]       System.Exception : Source information not available, make sure you are compiling with full debug information. Frame: ApiApprovalTests.PublicApi_Should_Not_Change_Unintentionally

@sungam3r Any ideas?

sungam3r commented 6 months ago

I'll take a look today. I think the difference is sdk-related. Try print API string on CI manually and then compare it with locally generated.

sungam3r commented 6 months ago

Related https://github.com/shouldly/shouldly/issues/574

sungam3r commented 6 months ago

Bingo! It failed only for net48. Now approval test runs only on net8.

ArieGato commented 6 months ago

Ahhh, great work!