ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

V7 release #153

Closed sungam3r closed 5 months ago

sungam3r commented 6 months ago

@ArieGato I would like to post some PRs before v7 if you OK.

ArieGato commented 6 months ago

What did you have in mind?

And is there something in github to structure these things. Some sort of Release planning

sungam3r commented 6 months ago

Some more cleanup, reorganize a bit project structure, CI changes. Maybe some API changes.

GitHub has projects feature but I don't use it. As I have seen these years devs just track such things as ordinal issues.

ArieGato commented 6 months ago

Well, then I would like to see them as issues so we can discuss them on forehand.

ArieGato commented 6 months ago

@sungam3r You mentioned something about the ci changes. What did you have in mind?

sungam3r commented 6 months ago

Changes in versioning - more simple way to set version. Changes in release triggers. Running dotnet format. I can not tell exactly the whole set of changes. I can do this in the near future.

ArieGato commented 6 months ago

@sungam3r Do you want to do some more cleaning before release v7? I was thinking about releasing.

sungam3r commented 6 months ago

Yes.

sungam3r commented 6 months ago

159 #160 #161

ArieGato commented 6 months ago

@sungam3r There are some merge conflicts that need to be resolved.

ArieGato commented 5 months ago

@sungam3r Are we ready for a v7 release?

sungam3r commented 5 months ago

I was away from my PC, let me check some stuff tomorrow monday and I'll return with answer.

sungam3r commented 5 months ago

The first thing I would like to close in v7 is #155.

sungam3r commented 5 months ago

I pushed some PRs with changes. I think I can make a few more (2-3) when merging those and all things will be ready for release.

sungam3r commented 5 months ago

For now I'm interested in #179.

sungam3r commented 5 months ago

Tomorrow I'll publish one more PR with TFM changes and I think that one will be the last for v7.

sungam3r commented 5 months ago

I'm done here and ready for release.

sungam3r commented 5 months ago

Oh, one more thing.

sungam3r commented 5 months ago

199

sungam3r commented 5 months ago

@ArieGato Would you like me to make new release https://github.com/ArieGato/serilog-sinks-rabbitmq/releases/new or will you do it yourself?

sungam3r commented 5 months ago

Just use tag v7.0.0 , prev tag 6.0.0 and generate release notes button.

ArieGato commented 5 months ago

If you could do it the first time, would be nice. I would like to know what options you select, so I can do it myself the next time.

sungam3r commented 5 months ago

изображение

изображение

sungam3r commented 5 months ago

https://github.com/ArieGato/serilog-sinks-rabbitmq/releases/tag/v7.0.0

Generate release notes button does the most work. After that you may change generated text in any way you want.

sungam3r commented 5 months ago

изображение

sungam3r commented 5 months ago

изображение

sungam3r commented 5 months ago

https://github.com/ArieGato/serilog-sinks-rabbitmq/releases/tag/v7.0.0

Note attached files: изображение

sungam3r commented 5 months ago

https://www.nuget.org/packages/Serilog.Sinks.RabbitMQ : изображение

sungam3r commented 5 months ago

изображение

ArieGato commented 5 months ago

Thnx @sungam3r ! Thanks for all the help and guidance!

sungam3r commented 5 months ago

Hah. Just noticed. You do not mind if I add myself to the list of authors? изображение

ArieGato commented 5 months ago

No you should be up there!