search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Implement RabbitMQ Client 7.0 #156

Open ArieGato opened 4 months ago

ArieGato commented 4 months ago

Investigate consequences of all breaking changes.

Can we support both versions? Maybe create two nuget packages.

sungam3r commented 4 months ago

Maybe create two nuget packages.

Not two packages with different names, but two different versions - v7 and v8. You already bumped serilog to v3 that is a breaking change. I suggest to accumulate all other changes in v7 except bumping rabbitmq to v7, release v7 of sink and then publish v8 of sink with rabbitmq v7.

ArieGato commented 4 months ago

This is definitly not going to be part of v7. It's more of a discussion about how we want to handle this.

At the moment RabbitMQClient 7 has an alpha status.

The question is whether we want to stop supporting RabbitMQClient 6.x in v8.

sungam3r commented 4 months ago

It depends of when rabbitmq goes from alpha to stable. It can be in alpha for years. V8 of this sink may have some unrelated to rabbitmq 7 breaking changes. Who knows.

sungam3r commented 3 months ago

https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/1413 https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/1056

lukebakken commented 1 month ago

Hello! I am the primary maintainer of the RabbitMQ .NET client. If you would like to speed along the release of version 7, testing alpha releases is a great way to help out -

https://www.nuget.org/packages/RabbitMQ.Client/7.0.0-alpha.6

I really would like to get everything wrapped up this month 🤞

ArieGato commented 1 month ago

@lukebakken Is there a migration guid?

I can't seem to find IModel.CreateBasicProperties.

lukebakken commented 1 month ago

@ArieGato no, there is no guide at this point in time. The API remains very similar to before, and the test suites are very thorough, so you should be able to figure out the necessary changes. If you need assistance, the best place to ask is here:

https://github.com/rabbitmq/rabbitmq-dotnet-client/discussions

One "big" change is the rename of IModel to IChannel.