search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

CI changes #161

Closed sungam3r closed 4 months ago

sungam3r commented 4 months ago
  1. Versioning with MinVer. All jumping around gitversion was removed.
  2. No tests for prerelease and release workflows - instead run tests on each pull request and push into master.
  3. Added: Upload Nuget packages as release artifacts.
  4. Added: tests for Windows OS.
  5. Added: dotnet format
sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sungam3r commented 4 months ago

Tests are green but that confuses a bit изображение

ArieGato commented 4 months ago

Tests are green but that confuses a bit !

yeah, starting the containers takes a little longer. We could extend the retry.

ArieGato commented 4 months ago

@sungam3r Do I need to tag the first commit after the 6.0.0 tag with 7.0.0-pre.0?

ArieGato commented 4 months ago

@sungam3r There are some merge conflicts that need to be resolved.

sungam3r commented 4 months ago

Do I need to tag the first commit after the 6.0.0 tag with 7.0.0-pre.0?

You may use any tag you want - MinVer will use it as a base. But remember that push to nuget.org happens only on release event when you make release via GitHub UI. There you choose release tag so tagging happens implicitly.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.17%. Comparing base (c575ecd) to head (0f3042f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #161 +/- ## ========================================== - Coverage 96.58% 96.17% -0.42% ========================================== Files 8 8 Lines 351 470 +119 Branches 42 42 ========================================== + Hits 339 452 +113 - Misses 5 11 +6 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sungam3r commented 4 months ago

Why so? You'll be able to accept many PRs in master before publishing all accumulated stuff publicitly to nuget.org. At the same time anyone can test any preview package created on each commit in master from your GitHub registry source.

sungam3r commented 4 months ago

All done here?

ArieGato commented 4 months ago

All done here?

I’m trying to add a tag on a specific commit back dated. The date of the tag is not set correctly.